[PWGEM] PhotonMeson: Remove ROOT dictionary generation#16860
Merged
mhemmer-cern merged 1 commit intoJun 29, 2026
Conversation
mhemmer-cern
commented
Jun 29, 2026
mhemmer-cern
commented
Collaborator
- Remove the ROOT dictionary generation, by removing the inheritance of TNamed for the cut classes. To ensure that everything still works added name and title private members with getter functions. Was tested on linux CentOS 8 stream.
- This should help the PR [Common,Tutorial,PWGJE,PWGUD] DPL Analysis: avoid including ASoA.h in dictionary generation #16823 so that the PhotonMeson part of PWGEM only needs new concepts header independent of ASoA.h, which was already discussed with @aalkin.
- Remove the ROOT dictionary generation, by removing the inheritance of TNamed for the cut classes. To ensure that everything still works added name and title private members with getter functions.
mhemmer-cern
requested review from
alibuild,
dsekihat,
hscheid and
jokonig
as code owners
|
O2 linter results: ❌ 102 errors, |
alibuild
approved these changes
Jun 29, 2026
alibuild
left a comment
alibuild
left a comment
Collaborator
There was a problem hiding this comment.
Auto-approving on behalf of @mhemmer-cern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.